corbz/ticket-website
1
0
Fork 0
Code Issues 4 Pull Requests Packages Projects 1 Releases 1 Wiki Activity

jones-dev #19

Merged
corbz merged 106 commits from jones-dev into master 2024-01-26 17:39:03 +00:00
Conversation 0 Commits 106 Files Changed 103 +96574 -78482
corbz commented 2024-01-26 17:38:35 +00:00
Owner
Copy Link
No description provided.
corbz added 106 commits 2024-01-26 17:38:36 +00:00 
While this contributes to #4, it doesn't complete it as the filters are still mostly eye candy.
some tickets were visible below the footer because it was transparent, so I gave it a background colour.
django rest framework
Improved filters and added TicketCount API View.
Instead of applying a list of __in filters at once, iterate over the list and apply them individually.

Only then will the tickets be filtered to match them all as intended.
Added buttons to move to the next or prev ticket from the current selected ticket.

Also segmented JS into functions.
Added .rounded-top-0, end-0, bottom-0, start-0, for setting the respective side to have border-radius of 0.

Also added .border-none for setting boder to none.

Added bg-none for setting background to none.
Added line to close the filter sidebar when selecting a ticket to open on a mobile screen.
Controls to specify whether to use the AND or OR operators when applying ticket filters.

I.e:
- Only show tickets with tag1 AND tag2
- Show tickets matching either tag1 OR tag2
NOTE:
when running without --noreload, there will be two log files, as Django runs two threads to make the auto reloading functionality work.
On smaller screens, expanding the filter sidebar would create scrollable whitespace below the page.

Hiding the .full-container overflow seems to patch the issue, although investigation is required to find a smoother patch.
Removed meaningless assets/ folder within static.

I believe its an artifact from an older Django version, but it needed to be removed to reduce clutter and use {% static %} tags.
Nice script to run the server.
Migrates before hand.
Runs on 0.0.0.0:8000 with the --noreload argument.
This can be used to test pagination, and feel for how the application experience will be under production.
The page would be above 1, and then would query the API with a new filter that reduced the results to a single page, causing an error.
Implemented tracking for this, over the previous code which tracked the active ticket by checking it's ".bgc-grey-100" class.

This change was made because (its better and) the previous implementation was incompatible with dark mode support.
returns a cleaned version of the description limited to 150 characters.

Suffixed with "...".
Was using BASE_DIR in the default image path for the authentication.User model.

This is a problem because BASE_DIR may change with the host machine, which it did in my case.

Django sees the changed path and incorrectly recommends making migrations again.
Previously 150.

I also added a check to see if 200 is exceeded before suffixing the "..." to it.
Added string datetime and indicators for priority and departments.

Also added a toggle for the indicators/departments to be shown.
because apps should always be made light mode first.

Makes it easier to implement nicer dark mode later on.
Just to add the base functionality, will improve upon this later.
Reviewed-on: https://gitea.corbz.dev/corbz/ticket-website/pulls/18
I've added a line in the updateItemsState function to reset the scrollbar to the top when the state changes.

This fixes #17
The theme will no longer reset to the default on page change or reload.
corbz merged commit 709c19f6e8 into master 2024-01-26 17:39:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jamesparkin corbz
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: corbz/ticket-website#19
No description provided.
Delete Branch "jones-dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?