refactor(api): cleaned the feed api code to be more maintainable, and added logging
This commit is contained in:
parent
99e1b0ef96
commit
dc3deffb32
@ -1,11 +1,15 @@
|
||||
import { Request, Response } from "express";
|
||||
import prisma, { Prisma } from "@server/prisma";
|
||||
import { datatableRequest } from "@server/controllers/guild/api/dt.module";
|
||||
import { logger } from "@server/../log";
|
||||
import { getLogger } from "@server/../log";
|
||||
|
||||
const logger = getLogger(__filename);
|
||||
|
||||
export const get = async (request: Request, response: Response) => {
|
||||
logger.info(`Getting feed: ${request.query.id}`);
|
||||
|
||||
if (!request.query.id) {
|
||||
response.status(400).json({ error: "missing 'id' query" });
|
||||
response.status(400).json({ error: "Missing 'id' query" });
|
||||
return;
|
||||
}
|
||||
|
||||
@ -15,162 +19,111 @@ export const get = async (request: Request, response: Response) => {
|
||||
});
|
||||
|
||||
if (!feed) {
|
||||
response.status(404).json({ message: "no result found" });
|
||||
response.status(404).json({ message: "No result found" });
|
||||
return;
|
||||
}
|
||||
|
||||
response.json(feed);
|
||||
};
|
||||
|
||||
const unpackChannels = (channels: string[] | string | undefined) => {
|
||||
if (channels === undefined) return channels;
|
||||
|
||||
return Array.isArray(channels)
|
||||
? channels.map(channelId => ({ channel_id: channelId }))
|
||||
: [{ channel_id: channels }];
|
||||
};
|
||||
|
||||
const unpackFilters = (filters: string[] | string | undefined) => {
|
||||
if (filters === undefined) return filters;
|
||||
|
||||
return Array.isArray(filters)
|
||||
? filters.map(filterId => ({ id: Number(filterId) }))
|
||||
: [{ id: Number(filters) }]
|
||||
};
|
||||
|
||||
export const post = async (request: Request, response: Response) => {
|
||||
const guildId = request.params.guildId;
|
||||
const {
|
||||
name,
|
||||
url,
|
||||
active,
|
||||
channels,
|
||||
filters,
|
||||
message_style,
|
||||
published_threshold
|
||||
} = request.body;
|
||||
logger.info(`Posting feed: ${request.body.url} - ${request.params.guildId}`);
|
||||
|
||||
logger.debug("Post Feed", request.body);
|
||||
const body = {
|
||||
...request.body,
|
||||
active: request.body.active === "on",
|
||||
message_style: Number(request.body.message_style) || null,
|
||||
published_threshold: new Date(request.body.published_threshold)
|
||||
};
|
||||
|
||||
// channels comes through as either String[] or String
|
||||
let formattedChannels = undefined;
|
||||
if (channels !== undefined) {
|
||||
formattedChannels = Array.isArray(channels)
|
||||
? channels.map((channelId) => ({ channel_id: channelId }))
|
||||
: [{ channel_id: channels }]
|
||||
}
|
||||
|
||||
let formattedFilters = undefined;
|
||||
if (filters !== undefined) {
|
||||
formattedFilters = Array.isArray(filters)
|
||||
? filters.map((filterId) => ({ id: Number(filterId) }))
|
||||
: [{ id: Number(filters) }]
|
||||
}
|
||||
|
||||
let feed;
|
||||
const createInputData: Prisma.FeedUncheckedCreateInput = {
|
||||
guild_id: request.params.guildId,
|
||||
name: body.name,
|
||||
url: body.url,
|
||||
active: body.active,
|
||||
channels: { create: unpackChannels(body.channels) },
|
||||
filters: { connect: unpackFilters(body.filters) },
|
||||
message_style_id: body.message_style,
|
||||
published_threshold: body.published_threshold
|
||||
};
|
||||
|
||||
try {
|
||||
feed = await prisma.feed.create({
|
||||
data: {
|
||||
name: name,
|
||||
url: url,
|
||||
guild_id: guildId,
|
||||
active: active === "on",
|
||||
channels: { create: formattedChannels },
|
||||
filters: { connect: formattedFilters },
|
||||
message_style_id: message_style === "" ? null : Number(message_style),
|
||||
published_threshold: new Date(published_threshold)
|
||||
}
|
||||
});
|
||||
const createResponse = await prisma.feed.create({ data: createInputData });
|
||||
response.status(201).json(createResponse);
|
||||
} catch (error) {
|
||||
logger.error(error);
|
||||
const isPrismaError = error instanceof Prisma.PrismaClientKnownRequestError;
|
||||
response.status(500).json({ error: isPrismaError ? error.message : error });
|
||||
}
|
||||
catch (error) {
|
||||
console.error(error);
|
||||
if (error instanceof Prisma.PrismaClientKnownRequestError) {
|
||||
response.status(500).json({ error: error.message });
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
response.status(201).json(feed);
|
||||
};
|
||||
|
||||
export const patch = async (request: Request, response: Response) => {
|
||||
const guildId = request.params.guildId;
|
||||
const {
|
||||
id,
|
||||
name,
|
||||
url,
|
||||
active,
|
||||
channels,
|
||||
filters,
|
||||
message_style,
|
||||
published_threshold
|
||||
} = request.body;
|
||||
logger.info(`Patching feed: ${request.body.id} - ${request.params.guildId}`);
|
||||
|
||||
logger.info("Patch Feed", request.body);
|
||||
const body = {
|
||||
...request.body,
|
||||
active: request.body.active === "on",
|
||||
message_style: Number(request.body.message_style) || null,
|
||||
published_threshold: new Date(request.body.published_threshold)
|
||||
};
|
||||
|
||||
// channels comes through as either String[] or String
|
||||
let formattedChannels = undefined;
|
||||
if (channels !== undefined) {
|
||||
formattedChannels = Array.isArray(channels)
|
||||
? channels.map((channelId) => ({ channel_id: channelId }))
|
||||
: [{ channel_id: channels }]
|
||||
}
|
||||
|
||||
let formattedFilters = undefined;
|
||||
if (filters !== undefined) {
|
||||
formattedFilters = Array.isArray(filters)
|
||||
? filters.map((filterId) => ({ id: Number(filterId) }))
|
||||
: [{ id: Number(filters) }]
|
||||
}
|
||||
|
||||
let feed;
|
||||
const updateInputData: Prisma.FeedUncheckedUpdateInput = {
|
||||
id: Number(body.id),
|
||||
name: body.name,
|
||||
url: body.url,
|
||||
active: body.active,
|
||||
channels: { deleteMany: {}, create: unpackChannels(body.channels) },
|
||||
filters: { set: [], connect: unpackFilters(body.filters) },
|
||||
message_style_id: body.message_style,
|
||||
published_threshold: body.published_threshold
|
||||
};
|
||||
|
||||
try {
|
||||
feed = await prisma.feed.update({
|
||||
where: { id: Number(id) },
|
||||
data: {
|
||||
name: name,
|
||||
url: url,
|
||||
guild_id: guildId,
|
||||
active: active === "on",
|
||||
channels: {
|
||||
deleteMany: {},
|
||||
create: formattedChannels
|
||||
},
|
||||
filters: {
|
||||
set: [],
|
||||
connect: formattedFilters
|
||||
},
|
||||
message_style_id:
|
||||
message_style === ""
|
||||
? null
|
||||
: Number(message_style),
|
||||
published_threshold: new Date(published_threshold)
|
||||
}
|
||||
});
|
||||
const updateArgs = { where: { id: Number(body.id) }, data: updateInputData };
|
||||
const updateResponse = await prisma.feed.update(updateArgs);
|
||||
response.status(200).json(updateResponse);
|
||||
} catch (error) {
|
||||
logger.error(error);
|
||||
const isPrismaError = error instanceof Prisma.PrismaClientKnownRequestError;
|
||||
response.status(500).json({ error: isPrismaError ? error.message : error });
|
||||
}
|
||||
catch (error) {
|
||||
console.error(error);
|
||||
if (error instanceof Prisma.PrismaClientKnownRequestError) {
|
||||
response.status(500).json({ error: error.message });
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
response.status(201).json(feed);
|
||||
}
|
||||
};
|
||||
|
||||
export const del = async (request: Request, response: Response) => {
|
||||
let { ids } = request.body;
|
||||
const guildId = request.params.guildId;
|
||||
logger.info(`Deleting feed(s): ${request.body.ids} - ${request.params.guildId}`);
|
||||
|
||||
if (!ids || !Array.isArray(ids)) {
|
||||
response.status(400).json({ error: "invalid request body" });
|
||||
const ids = request.body.ids?.map((id: string) => Number(id));
|
||||
|
||||
if (!ids) {
|
||||
response.status(400).json({ error: `Couldn't parse ID's from request body` });
|
||||
return;
|
||||
}
|
||||
|
||||
ids = ids.map(id => Number(id));
|
||||
|
||||
try {
|
||||
await prisma.feed.deleteMany({ where: {
|
||||
id: { in: ids },
|
||||
guild_id: guildId
|
||||
}});
|
||||
const deleteArgs = { where: { guild_id: request.params.guildId, id: { in: ids } } };
|
||||
await prisma.feed.deleteMany(deleteArgs);
|
||||
response.status(204).send();
|
||||
} catch (error) {
|
||||
logger.error(error);
|
||||
const isPrismaError = error instanceof Prisma.PrismaClientKnownRequestError;
|
||||
response.status(500).json({ error: isPrismaError ? error.message : error });
|
||||
}
|
||||
catch (error) {
|
||||
console.error(error);
|
||||
if (error instanceof Prisma.PrismaClientKnownRequestError) {
|
||||
response.status(500).json({ error: error.message });
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
response.status(204).json(null);
|
||||
};
|
||||
|
||||
export const datatable = async (request: Request, response: Response) => {
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user