From c398cac067b23f89fc851c58b121ef00345ef1d4 Mon Sep 17 00:00:00 2001 From: Corban-Lee Jones Date: Sun, 8 Dec 2024 00:46:57 +0000 Subject: [PATCH] fix improper generator use --- utils/reader.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/utils/reader.py b/utils/reader.py index b73cb96..ee55509 100644 --- a/utils/reader.py +++ b/utils/reader.py @@ -21,7 +21,7 @@ class LogFileReader: self._last_line_number = 0 log.debug("%s created with path %s", self.__class__.__name__, str(file_path)) - async def read(self): + async def read(self) -> list[str]: if not self.file_path.exists(): log.error("Cannot read non-existant file path: '%s'", self.file_path) raise FileNotFoundError(self.file_path) @@ -30,17 +30,13 @@ class LogFileReader: if self._last_line_number == 0: await file.seek(0, 2) self._last_line_number = await file.tell() - return + return [] await file.seek(self._last_line_number) lines = await file.readlines() if not lines: log.debug("no new lines to read") - return + return [] self._last_line_number = await file.tell() - - log.debug("lines to yield: %s", len(lines)) - for line in lines: - yield line.strip() - + return lines