Various Code Improvements #47

New Issue

corbz · 2024-08-20T13:27:22Z

corbz commented

2024-08-20 13:27:22 +00:00

I've reviewed through for areas of code that require improvement, here are some ideas:

One SavedGuild for multiple users.
- Foreign Key GuildSettings to SavedGuild, drop the guild_id attr.
BigIntegerFields for Discord Snowflake ID's (previously there was a rounding issue with PositiveBigIntegerField in sqlite, investigate)
Use Discord Provided Snowflake ID's as primary keys

Index Foreign Keys

class SavedGuilds(models.Model):
    # Other fields...
    class Meta:
        indexes = [
            models.Index(fields=['guild_id']),
            models.Index(fields=['added_by']),
        ]

These changes will be breaking, naturally, and will require a at least a minor or major version change.

I've reviewed through for areas of code that require improvement, here are some ideas: 1. One `SavedGuild` for multiple users. - Foreign Key `GuildSettings` to `SavedGuild`, drop the `guild_id` attr. 2. `BigIntegerField`s for Discord Snowflake ID's (previously there was a rounding issue with `PositiveBigIntegerField` in sqlite, investigate) 3. Use Discord Provided Snowflake ID's as primary keys 4. Index Foreign Keys ``` class SavedGuilds(models.Model): # Other fields... class Meta: indexes = [ models.Index(fields=['guild_id']), models.Index(fields=['added_by']), ] ``` These changes will be breaking, naturally, and will require a at least a minor or major version change.

corbz added the

enhancement

label 2024-08-20 13:27:22 +00:00

corbz self-assigned this 2024-08-20 13:27:22 +00:00

corbz added this to the PYRSS project 2024-08-20 13:27:22 +00:00

corbz commented

2024-08-20 13:28:09 +00:00

I will break these down into smaller issues, and lock this one behind the completion of those.

corbz referenced this issue

2024-08-20 13:30:54 +00:00

Rewrite: 1 SavedGuild for Every User #48

corbz added a new dependency 2024-08-20 13:31:05 +00:00